Project

General

Profile

Feature #1633

Allow special characters in type names

Added by Aleksandra Apic 8 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
Backend
Target version:
Start date:
2022-01-25
Estimated time:

Description

Wäre es möglich auch Schrägstriche im Namen zu erlauben?

Beispiel unter Custom Type>Language:

Bilingual Sarada/Arabic

Update
Special characters are now allowed in types similar to the rest of application (e.g. HTML tags are still filtered).


Files

Slash.png (8.71 KB) Slash.png Aleksandra Apic, 2022-01-25 16:31

History

#1

Updated by Alexander Watzinger 8 months ago

Thank you very much for reporting.
In the backend I saw no obvious reason to not allow slashes in type name but I added other developers as watcher in case they have reasons not to allow it.
Lets see what they say.

#2

Updated by Alexander Watzinger 8 months ago

Type names are a little special and concerns about allowing slashes were already voiced.
Because we have to be careful to not e.g. break functionality in API, presentation sites, ... I put it on the agenda for the next OpenAtlas developer meeting.
So although the request may seem trivial it will take some time to process.

#3

Updated by Alexander Watzinger 8 months ago

  • Category set to Backend
  • Status changed from New to In Progress
  • Target version set to 7.4.0
#4

Updated by Alexander Watzinger 8 months ago

  • Subject changed from Allow slashes in type names to Allow special characters in type names
We discussed using special characters in type names in today's developer meeting.
There were some reservation but it's likely we need it in the long run more often, e.g. when importing already existing vocabularies.
Because the sooner the better we decided to implement it in the near future but are being careful and do it step by step to test components individually, in that order:
  • Backend
  • UI
  • API
  • Presentation sites, e.g. THANADOS

So I, Alex, will begin a new branch, implement it in the backend and than hand it over to other developers.

#5

Updated by Alexander Watzinger 4 months ago

  • Description updated (diff)
  • Status changed from In Progress to Closed
  • Assignee set to Alexander Watzinger

After some consideration I decided to allow special characters in types similar to the rest of application (e.g. HTML tags are still filtered). I also decided to not hand this over to one developer after another for testing because it would take too long.
I implemented and tested it in the backend. So far I didn't run into obvious problems but you (Andi, Bernhard, Stefan, ...) might want to test (locally) your frontends/API just in case.
There should be no immediate problems with existing data but in case things get problematic, we can discuss this again.
It's already in the develop branch and online on demo-dev and THANADOS.

Thanks again for reporting.

Also available in: Atom PDF