Feature #2321
closedAPI: Missing places in network endpoint
Description
I encountered problems with some endpoints: the query endpoint returns places that the network endpoint does not. (e.g., entity Meteora, ID: 356 on the mamems instance) --> in the network endpoints return no such place entity is found.
Updated by Bernhard Koschiček-Krombholz 4 months ago
- Status changed from Acknowledged to In Progress
- Assignee set to Bernhard Koschiček-Krombholz
- Tracker changed from Bug to Feature
This is again a problem with P74_has_current_or_former_residence which links to E53 Location of Meteora and not actual E18 Meteora. You can see in this request https://mamems.openatlas.eu/api/0.4/network_visualisation/?linked_to_ids=1073 there is the link to Location of Meteora (ID: 357), since this is the link provided by the database.
Since it makes what it should do, I took the freedom to change it from Bug to Feature, because it is a request, to change correct but unsuspected behavior. I will look into it right away.
Updated by Bernhard Koschiček-Krombholz 4 months ago
- Status changed from In Progress to Acknowledged
- Assignee deleted (
Bernhard Koschiček-Krombholz)
Ok, looked into it. It will take some time to figure it in a way that cost not so much performance.
If it is not terrible important, I will postpone it until I return.
Updated by Alexander Watzinger 4 months ago
I would say it can wait till you return. If not, I will look into it.
But thanks a lot for your valuable feedback, I now think I know what this is about.
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Assignee set to Bernhard Koschiček-Krombholz
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Status changed from Acknowledged to Resolved
- Assignee changed from Bernhard Koschiček-Krombholz to Olivia Reichl
Now there should be additionally to the object_location ("Location of Meteora") the place "Meteora" which has all links which the location also have. You can easily ignore the object_location with ?exclude_system_classes=object_location
Example result:
... { "id": 356, "label": "Meteora", "systemClass": "place", "relations": [ 1073, 1322, 357, 361, 329, 330 ] }, { "id": 357, "label": "Location of Meteora", "systemClass": "object_location", "relations": [ 356, 1073, 1322 ] } ...
Changes are already up-to-date in MAMEMS.
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Status changed from Resolved to In Progress
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Related to Feature #2346: API: 0.4.4 added
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Assignee changed from Olivia Reichl to Bernhard Koschiček-Krombholz
- In the example of Meteora, it seems that the group Meteora (1073) doesn't know about the place (356)
- There is a problem, if the network of a type (e.g. Case Study) should be shown, but
type
is excluded, then no objects will return. Maybe just show only the Case Study type and exclude all other types. But then e.g. MAMEMS would be the center of the network, which would also be confusing.
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Status changed from In Progress to Closed
Fix both issues. Will be in develop next week, need to refactor.
Updated by Bernhard Koschiček-Krombholz about 1 month ago
- Status changed from Closed to In Progress
Updated by Bernhard Koschiček-Krombholz 28 days ago
- Status changed from In Progress to Closed
In develop.
Updated by Bernhard Koschiček-Krombholz 28 days ago
- Subject changed from API: The query endpoint returns places, which the network endpoint does not return. to API: Missing places in network endpoint