Project

General

Profile

Actions

Feature #940

closed

Multiple file upload

Added by Bernhard Koschiček-Krombholz about 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Backend
Target version:
Start date:
2018-09-27
Estimated time:

Description

It would be nice to have a file upload for multiple files. But not like a .zip file which unpack it self, just a select window which takes more files as input. The licensing is the same for the whole batch.

Actions #1

Updated by Alexander Watzinger about 6 years ago

  • Status changed from New to Acknowledged
Actions #2

Updated by Bernhard Koschiček-Krombholz over 3 years ago

  • Assignee set to Bernhard Koschiček-Krombholz
  • Target version changed from Wishlist to 6.3.0
Actions #3

Updated by Bernhard Koschiček-Krombholz over 3 years ago

  • Status changed from Acknowledged to In Progress
Actions #4

Updated by Bernhard Koschiček-Krombholz over 3 years ago

If multiple files are uploaded, they will have the same name with a number behind them.
What format is better for readability and working? Possibilities:

filename_0.jpg
filename_1.jpg
filename_2.jpg

or

filename_01.jpg
filename_02.jpg
filename_03.jpg

or

filename.jpg
filename_01.jpg
filename_02.jpg

or

filename.jpg
filename_02.jpg
filename_03.jpg
(This is my preference)

Please state your opinion or the last option will be implemented.

Actions #5

Updated by Alexander Watzinger over 3 years ago

I like 01, 02, 03 ... more but be aware that it would be possible to upload more than 99. Not to say that we are writing 001, just be aware of that when writing the function.

Actions #6

Updated by Bernhard Koschiček-Krombholz over 3 years ago

Oh hell yes! In the code I was aware, but here I didn't though of it.

The numbers should be without trailing zeros, because of the reasons you wrote. So the options are:

filename_0.jpg
filename_1.jpg
filename_2.jpg

or

filename_1.jpg
filename_2.jpg
filename_3.jpg

or

filename.jpg
filename_1.jpg
filename_2.jpg

or

filename.jpg
filename_2.jpg
filename_3.jpg

Actions #7

Updated by Alexander Watzinger over 3 years ago

I would say when it's only one than just the filename. Otherwise I still prefer filename_01, filename_02, ... you can do this with just adding a leading number in case its only one digit.

One way to do it would be using zfill() like we do in OpenAtlas in models/date.py (https://github.com/craws/OpenAtlas/blob/main/openatlas/models/date.py)
Here is also a link with an explanation and examples: https://www.askpython.com/python/string/python-string-zfill

Actions #8

Updated by Bernhard Koschiček-Krombholz over 3 years ago

  • Status changed from In Progress to Resolved
  • Target version changed from 6.3.0 to 6.2.0

Thank you, Alex, for the advice.
With this done, I would say, the feature is done. The only thing is left to do is expand the manual, but this will be done in develop.

So if there are no objections, I will merge it.

Actions #9

Updated by Alexander Watzinger over 3 years ago

Great! Merge it to develop. We can look at the manual together if you like.
You can close the ticket (once in develop) even with missing manual because that's more part of the release workflow than the ticket itself.

Actions #10

Updated by Bernhard Koschiček-Krombholz over 3 years ago

  • Status changed from Resolved to Closed
Actions #11

Updated by Alexander Watzinger over 3 years ago

  • Subject changed from Multiple File Upload to Multiple file upload
Actions

Also available in: Atom PDF