So I looked into it and pushed some changes into the feature branch. There are multiple topics
Import of JavaScript libraries¶
Since we don't want to depend on loading external scripts I changed it to be loaded the "npm" way. You can try this yourself the next time (the author even noted this in his readme) with editing the openatlas/static/package.json file.
To get the changes, you have to run something like this after pulling the feature branch:
$ cd openatlas/static
$ pip3 install -e ./
$ ~/.local/bin/calmjs npm --install openatlas
I also did some stuff like joining the overlay templates, fixing tests, merging newest develop version and the like.
Former values¶
Not sure what you mean with you couldn't test because you don't have the files locally. I don't have them either so I just created some. When testing it with images created the old way (so adding them in develop) they still displayed correctly (in the new feature branch) but when trying to edit them there is a script error because you renamed/added variables e.g.
File "/home/alex/projects/www/openatlas/openatlas/views/overlay.py", line 75, in overlay_update
form.bottom_left_easting.data = bounding[2][1]
IndexError: list index out of range
We can't leave it like this. One rather radical solution would be to delete all existing overlay data but you may want to look into this.
Also, even if the form would display somehow, all 6 (new) values seem to be required so it would be problematic with only 4 from the old system.
Manual¶
Before adding this feature we need an updated manual entry for overlays, see at the bottom of:
https://demo.openatlas.eu/static/manual/tools/map.html#map-overlay. I guess the easiest way would be to post some text here and I get it into the actual manual.
Further steps¶
Once you solved the incompatible issue with the old values and provided an updated manual text, I can merge this into develop.