Bug #1636
closed
Geometry edit on place level vanished
Description
In the current development version of 7.1.0 the buttons for geometry insert in the map (in edit mode) are no longer shown on the place level. On other levels they are there.
Updated by Alexander Watzinger almost 3 years ago
- Category set to Maps
- Status changed from New to In Progress
- Assignee set to Alexander Watzinger
- Target version set to 7.1.0
- Estimated time set to 1.00 h
Can confirm this issue in the develop version 7.1.0 and will look into it. Thanks for reporting.
Updated by Alexander Watzinger almost 3 years ago
- Assignee changed from Alexander Watzinger to Andreas Olschnögger
The problem is this line in openatlas/static/js/map/draw.js on top:
var name;
It throws an error if name is already set. In this case it seems to originate from the new alias feature because in a place view it is already set (with alias in case of insert).
So assigning this to @Andreas Olschnögger, could you please change it in the new alias function and not use name as a variable name. I really don't want to change and maybe break things in the old map module which we want to replace anyway.
Updated by Alexander Watzinger almost 3 years ago
- Related to Feature #1593: Adding multiple aliases at once instead one at a time added
Updated by Alexander Watzinger almost 3 years ago
I hope it's possible to change it in the alias function, I just thought it might be a generic issue related to the name form field. In that case we would have to think of something else.
Updated by Alexander Watzinger almost 3 years ago
Maybe it would suffice to set it empty in draw.js? I'm really not an expert in JavaScript.
Updated by Andreas Olschnögger almost 3 years ago
- Status changed from In Progress to Closed
It should be fixed now. I've added the prefix rlf (removable list field) to every variable inside the removable_list_field.html so they will no longer interfere with other components.
Updated by Alexander Watzinger almost 3 years ago
- Target version deleted (
7.1.0)
The solution with the prefix seem to have solved the issue. I uploaded the new version to demo-dev (see: https://demo-dev.openatlas.eu/insert/place) and the THANADOS test instance.
Thank you Stefan for reporting and Andi for fixing.