Actions
Feature #1734
closedForms: refactor functions
Start date:
2022-06-06
Estimated time:
16.00 h
Description
Because of the generic form functions, which is generally a good approach to manage the complex model relations, we ended up with very long if/else constructs that can get quite confusing.
This concerns especially the functions at openatlas/forms:
This concerns especially the functions at openatlas/forms:
- process_form_data()
- process_origin_data()
- populate_update_form()
- additional_fields()
After testing a new approach with similar software we decided to remedy this with creating form manager classes that handle specific entity (and link) forms individually instead of using growing if/else constructs for all forms, before adding functionality in this area.
Miscellaneous refactoring- Moving logger from app to g
- Solving some non top level imports
- Replacing if/else with or
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1587: Link artifacts and human remains to places directly added
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1637: Linking subunits like places, e.g. with events added
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1641: Acquisition in combination with artifacts added
Updated by Alexander Watzinger over 2 years ago
- Related to Feature #1647: Composition of artifacts and human remains added
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1648: Relative Chronological/Spatial relation between two artifacts added
Updated by Alexander Watzinger over 2 years ago
- Related to deleted (Feature #1647: Composition of artifacts and human remains)
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1647: Composition of artifacts and human remains added
Updated by Alexander Watzinger over 2 years ago
- Status changed from Acknowledged to In Progress
- Assignee set to Alexander Watzinger
Updated by Alexander Watzinger over 2 years ago
- Precedes Feature #1750: Linking movements with line objects, e.g. roads added
Updated by Alexander Watzinger over 2 years ago
- Related to Feature #1761: Forms: don't show empty type fields added
Updated by Alexander Watzinger over 2 years ago
- Subject changed from Refactor form functions to Forms: refactor functions
Updated by Alexander Watzinger over 2 years ago
- Related to Feature #1768: Forms: improved validations added
Updated by Alexander Watzinger over 2 years ago
- Status changed from In Progress to Closed
Actions