Actions
Feature #1734
closedForms: refactor functions
Start date:
2022-06-06
Estimated time:
16.00 h
Description
Because of the generic form functions, which is generally a good approach to manage the complex model relations, we ended up with very long if/else constructs that can get quite confusing.
This concerns especially the functions at openatlas/forms:
This concerns especially the functions at openatlas/forms:
- process_form_data()
- process_origin_data()
- populate_update_form()
- additional_fields()
After testing a new approach with similar software we decided to remedy this with creating form manager classes that handle specific entity (and link) forms individually instead of using growing if/else constructs for all forms, before adding functionality in this area.
Miscellaneous refactoring- Moving logger from app to g
- Solving some non top level imports
- Replacing if/else with or
Actions