Feature #1835
closed
Improved form selection behavior
Description
Update
Now, if a modal window for table multi selects or tree multi select is closed with clicking outside, the information is still transferred. So no need to aim for the close button anymore.
Original issue text
Upon exiting the Actor selection table I'd expect my choices to be applied no matter how I exit it, not just when clicking on the "close" button in the bottom right corner. Especially since the information is saved within the table.
Maybe the close button be renamed to save?
See, e.g.: https://demo.openatlas.eu/involvement/insert/6490
Alex +1 (for selecting changes even when closing with clicking somewhere else)
Updated by Alexander Watzinger about 2 years ago
- Subject changed from Event Actor Involvment, UX decisions: Should selected Actors be saved when exiting the table without the close button? Should the close button be renamed to save? to Should selected entries be saved when exiting layovers without the close button?
- Description updated (diff)
- Status changed from New to Assigned
- Assignee set to Andreas Olschnögger
I (and Nina) would also prefer that just exiting the window will accept the selection.
Updated by Andreas Olschnögger about 2 years ago
I agree with you. It is indeed counterintuitive. Especially because with a fully populated table the button at the bottom is not visible.
The question is, what if I don't want to save the changes I make? If we would also save when closing the pupup then there would be no way to discard changes. (The question is if someone really needs to discard changes)
I would suggest to rename the button to save and to limit the height of the table by making the table inside the popup scrollable, so that the save button is always visible.
If it is not necessary to reset the table, I would say that closing the table in whatever way is to save the data.
If we keep discarding changes when closing the table, then we need to make sure that when we reopen the table, it is also reset.
Updated by Alexander Watzinger about 2 years ago
- Tracker changed from Question to Feature
- Subject changed from Should selected entries be saved when exiting layovers without the close button? to Improved form selection behavior
- Target version set to 7.12.0
So we have 2 issues here:
1) Behavior
We should change it in any case because now when clicking somewhere else the table "remembers" the selection but the form doesn't which is inconsistent. When fixing this we should also do this for multi tree selects. That's why I turned this question to a feature issue.
As mentioned before I (and some others) are in favor that closing when clicking outside also takes over the selection because data entry gets much quicker that way.
I don't see a problem with discarding the changes, if it is "saved" like when now clicking the submit button you have the visual feedback in the form and it can be reopened again and adjusted. Combined with the fact that this tables can be sorted at the select box column, it makes this pretty easy. Or you just don't save the form at all if you didn't like what you entered.
2) Layout
I'm not sure if we can do much about it if you have to scroll for the submit button at table popups, which of course isn't ideal. Whether the button is visible is a combination of configured shown table rows and available screen space which can differ a lot. However, being able to close it with clicking anywhere would help with that too.
Updated by Andreas Olschnögger about 2 years ago
- Status changed from Assigned to Closed
Now changes are safed when closing the modal.
The modal body height is now limited so the save button is always visible.
Changes are already in develop branch
Updated by Alexander Watzinger about 2 years ago
- Status changed from Closed to In Progress
- Target version changed from 7.12.0 to 7.8.0
I tested the multi table selection and it works great, thanks a lot.
However, for consistency we would also need this for multi tree field selection (I mentioned it before in the notes where it is easy to miss).
You could try and test this with e.g. insert place and selecting multiple administrative units.
Updated by Alexander Watzinger about 2 years ago
- Description updated (diff)
- Status changed from In Progress to Closed
Thanks for implementing it for the multi tree fields too, works great. Although this seems only a minor change it will improve usability a lot.
I also took the liberty to rename the button from "save" to "close" again because technically, nothing is saved in this step.
It's already on the development demo version for anyone who wants to try it out: https://demo-dev.openatlas.eu/insert/place