OpenAtlas

Good idea, we could try to use the backend error views located at views/index.py. If we differentiate in these functions if the call is from API and e.g. don't use the templates it could be easily called inside the API with e.g.

abort(404)

As for which we need: I think 404 (not found) and 403 (forbidden) would be the most essential ones. You can see what else is already implemented for the backend at views/index.py.

A first model for the API error handling is finished and run through nosetests. @Alexander Watzinger: do you want to look it through in the feature_api branch or should I just merge it to develop?

I pushed it to develop.

Reopening this issue because tests still didn't passed in the develop branch.

One issue that was really hard to track down (turned out it occurs only if the route begins with "/api") was that in index.py API errors tried to return something like

APIError('Forbidden', status_code="403").to_dict()

which caused an error, I fixed it for now with casting it to a string like:

str(APIError('Forbidden', status_code="403").to_dict())

but not sure if this is what you wanted or needed so please take a look at it.

Also the 404b error is still comment out because 'actor' is passed as argument where an int is expected and not handled properly.

Sadly our last fixes didn't made it to the develop branch (they seemed to be made only in some API branch) so I fixed it in develop (again). Please, make sure that develop tests are passing at all times and also take care with latest changes because you surly will get merge conflicts after work was done in different branches.

Please keep this issue open until everything is straightened out, if finished (merged in develop and all tests pass as expected) assign it to me with a comment. I will test again on my machine because as we noticed last time, some errors don't seem to show up on your machine.

@Alexander Watzinger: can you please check if the test will work now? It is under the feature_api branch.

But maybe we can get together after your holidays, because it is hard to fix an error, which I can't replicate.

All tests and Mypy checks are working, even in the newest develop version. Assigning back.

The error handling is for now sufficient and covers every API error occurrence. Thanks to Alex for testing.