Project

General

Profile

Feature #1866

Complete Bootstrap layout

Added by Alexander Watzinger 3 months ago. Updated 5 days ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
2022-11-10
Estimated time:

Description

Andi noticed that there are some artifacts from the original, non Bootstrap, layout system. E.g. styling of form fields. Thanks to Andi for bringing it up and offer to take care about it.
The new layout can be seen and tested at the development demo: https://demo-dev.openatlas.eu


Related issues

Precedes OpenAtlas - Feature #1906: Unify placement of form error messagesClosed2022-11-11Actions
Precedes OpenAtlas - Feature #1918: Capitalization of first letter with CSSIn Progress2022-11-11Actions

History

#1

Updated by Alexander Watzinger about 2 months ago

  • Precedes Feature #1906: Unify placement of form error messages added
#2

Updated by Alexander Watzinger about 2 months ago

  • Target version changed from 7.11.0 to 7.9.0
#3

Updated by Alexander Watzinger about 2 months ago

  • Target version changed from 7.9.0 to 7.10.0
#4

Updated by Andreas Olschnögger 21 days ago

  • Precedes Feature #1918: Capitalization of first letter with CSS added
#5

Updated by Alexander Watzinger 14 days ago

  • Subject changed from Layout to full Bootstrap to Complete Bootstrap layout
  • Description updated (diff)
  • Status changed from Assigned to In Progress

Thanks a lot Andi for implementing this, the work in progress can be seen at the development demo: https://demo-dev.openatlas.eu
It's also already in the develop branch. Please report problems you notice in this issue.

At a first glance it seems to work well, issues I noticed (using Firefox 102.6.0esr):
At insert actor: https://demo-dev.openatlas.eu/insert/person
  • There is a top line border (.table > :not(:first-child) {border-top: 2px solid currentColor;} in _tables.scss
  • When using a table field e.g. Residence, the table overlay has a vertical scrollbar, if used it just shows empty space on the right.
  • When a type hierarchy was created but has no subs (so nothing to select), they shouldn't be included in the form but they appear now in the new layout
#6

Updated by Alexander Watzinger 14 days ago

  • Description updated (diff)

I added a known issues to the description to collect unsolved items there.

I noticed that the tab/URL targeting isn't working anymore. E.g.
#7

Updated by Alexander Watzinger 14 days ago

  • Description updated (diff)
#8

Updated by Alexander Watzinger 14 days ago

  • Description updated (diff)

At some tables the "Showing 1 to 12 of 12 entries" string is a 2 liner e.g. overview table on start page at https://demo-dev.openatlas.eu/

By the way, the double posting in notes and description is so that solved issues can be removed from the description but are still documented in the notes. If you, Andi, prefer another workflow, we can change that of course.

#9

Updated by Andreas Olschnögger 13 days ago

  • Description updated (diff)
#10

Updated by Alexander Watzinger 13 days ago

  • Description updated (diff)
Thanks for the quick fixes, I try to keep the dev-demo up to date to reflect the changes.
I could solve that empty types don't show up (it happened with value types).
And added:
#11

Updated by Alexander Watzinger 13 days ago

  • Description updated (diff)
#12

Updated by Alexander Watzinger 12 days ago

  • Description updated (diff)
#13

Updated by Andreas Olschnögger 11 days ago

  • Description updated (diff)
#14

Updated by Alexander Watzinger 11 days ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved

As always, thanks Andi for the quick fixes.
It looks great and I didn't notice anything else but if anyone does before the release, please post it in this issue.
You can see newest changes at the development demo: https://demo-dev.openatlas.eu

#15

Updated by Alexander Watzinger 5 days ago

  • Status changed from Resolved to Closed

Closing this because we didn't find more issues recently. Looks very good and thanks for the great work!

Also available in: Atom PDF