Feature #1866
closed
Complete Bootstrap layout
Description
Andi noticed that there are some artifacts from the original, non Bootstrap, layout system. E.g. styling of form fields. Thanks to Andi for bringing it up and offer to take care about it.
The new layout can be seen and tested at the development demo: https://demo-dev.openatlas.eu
Updated by Alexander Watzinger almost 2 years ago
- Precedes Feature #1906: Unify placement of form error messages added
Updated by Alexander Watzinger almost 2 years ago
- Target version changed from 7.12.0 to 7.9.0
Updated by Alexander Watzinger almost 2 years ago
- Target version changed from 7.9.0 to 7.10.0
Updated by Andreas Olschnögger almost 2 years ago
- Precedes Feature #1918: Capitalization of first letter with CSS added
Updated by Alexander Watzinger almost 2 years ago
- Subject changed from Layout to full Bootstrap to Complete Bootstrap layout
- Description updated (diff)
- Status changed from Assigned to In Progress
Thanks a lot Andi for implementing this, the work in progress can be seen at the development demo: https://demo-dev.openatlas.eu
It's also already in the develop branch. Please report problems you notice in this issue.
At insert actor: https://demo-dev.openatlas.eu/insert/person
- There is a top line border (.table > :not(:first-child) {border-top: 2px solid currentColor;} in _tables.scss
- When using a table field e.g. Residence, the table overlay has a vertical scrollbar, if used it just shows empty space on the right.
- When a type hierarchy was created but has no subs (so nothing to select), they shouldn't be included in the form but they appear now in the new layout
Updated by Alexander Watzinger almost 2 years ago
- Description updated (diff)
I added a known issues to the description to collect unsolved items there.
I noticed that the tab/URL targeting isn't working anymore. E.g.- If I'm in an actor view (https://demo-dev.openatlas.eu/entity/20701#tab-event)
- And add an event in the event tab with "link"
- I get redirected to the actor view (correct) but not the event tab although the URL says so: https://demo-dev.openatlas.eu/entity/20701#tab-event
Updated by Alexander Watzinger almost 2 years ago
- Description updated (diff)
At some tables the "Showing 1 to 12 of 12 entries" string is a 2 liner e.g. overview table on start page at https://demo-dev.openatlas.eu/
By the way, the double posting in notes and description is so that solved issues can be removed from the description but are still documented in the notes. If you, Andi, prefer another workflow, we can change that of course.
Updated by Alexander Watzinger almost 2 years ago
- Description updated (diff)
I could solve that empty types don't show up (it happened with value types).
And added:
- class error doesn't render red font color (#721c24) anymore, e.g. form error at login without username
- Required star in next line (e.g. login https://demo-dev.openatlas.eu/login) and other line breaks in form labels (e.g. "Stylistic Classification" at https://demo-dev.openatlas.eu/insert/place)
I guess that could be fixed with "white-space: nowrap"?
Updated by Alexander Watzinger almost 2 years ago
- Description updated (diff)
- Status changed from In Progress to Resolved
As always, thanks Andi for the quick fixes.
It looks great and I didn't notice anything else but if anyone does before the release, please post it in this issue.
You can see newest changes at the development demo: https://demo-dev.openatlas.eu
Updated by Alexander Watzinger almost 2 years ago
- Status changed from Resolved to Closed
Closing this because we didn't find more issues recently. Looks very good and thanks for the great work!